Upgrade dependencies, misc. fixes #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myabc
changed the title
Although Bluebird appears to support ES5 at runtime, its typings now depend on ES6 Map: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/00cb71a36a31ec77e0f8c4c4598cc7d457385bf1/types/bluebird/index.d.ts#L660
myabc
commented
Oct 31, 2017
| ); | ||
|
|
||
| let outName = this.getOutName(doc.namespace.name); | ||
| if (doc.namespace.isPrimitiveSpace || new Address(outName).isLocal) { |
Author
There was a problem hiding this comment.
@charto This is a big hack - Although I suspect there is a better way of doing this, this is the best I could come up with.
myabc
changed the title
Member
|
Thanks! Could you remove the yarn.lock file? Then I can merge. |
jjrv
reviewed
Nov 1, 2017
| "removeComments": false, | ||
| "target": "es5" | ||
| "target": "es5", | ||
| "lib": ["es6"] |
Member
There was a problem hiding this comment.
This could be just: [ "es5", "es2015.collection" ]
|
Is there anything blocking this pull request?
|
|
What's the status of this pull request? |
Author
|
I no longer have write access to the OUP repository so will need to open new PR |
Author
|
Replaced by PR #27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains dependency updates (two commits taken from
develop) + minimal fixes needed to get cxsd building. I'll leave refactorings/feature ideas to another PR.